On Fri, Oct 19, 2018 at 10:34 AM Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> wrote: > > > struct collect_changed_submodules_cb_data { > + struct repository *repo; This slightly overlaps with sb/submodule-recursive-fetch-gets-the-tip, but we can have this patch on its own as I have to rebuild that series, will build on top of this. The patch looks good, Stefan