On Wed, Oct 10, 2018 at 11:59:38AM -0400, Ben Peart wrote:
> +static unsigned long load_cache_entries_threaded(struct index_state *istate, const char *mmap, size_t mmap_size,
> + unsigned long src_offset, int nr_threads, struct index_entry_offset_table *ieot)
The src_offset parameter isn't used in this function.
In early versions of the series, it was used to feed the p->start_offset
field of each load_cache_entries_thread_data. But after the switch to
ieot, we don't, and instead feed p->ieot_start. But we always begin that
at 0.
Is that right (and we can drop the parameter), or should this logic:
> + offset = ieot_start = 0;
> + ieot_blocks = DIV_ROUND_UP(ieot->nr, nr_threads);
> + for (i = 0; i < nr_threads; i++) {
> [...]
be starting at src_offset instead of 0?
-Peff
