> On Wed, Oct 17, 2018 at 5:41 AM Derrick Stolee <stolee@xxxxxxxxx> wrote:
>> I had one high-level question: How are we testing that these "arbitrary
>> repository" changes are safe?
> [...]
> Or instead we could accelerate the long term plan of removing a
> hard coded the_repository and have each cmd builtin take an additional
> repository pointer from the init code, such that we'd bring all of Git to
> work on arbitrary repositories. Then the standard test suite should be
> okay, as there is no special case for the_repository any more.
Demo'd in this RFC series for git-merge-base.
The core idea is found in patch 1,
and the proof of concept is found in patch 2.
What do you think?
Thanks,
Stefan
Stefan Beller (3):
repository: have get_the_repository() to remove the_repository
dependency
builtin/merge-base.c: do not rely on the_repository any more
builtin/merge-base.c | 67 ++++++++++++++++++++++++++-----------------
repository.c | 10 +++++++
repository.h | 13 ++++++++-
t/t6010-merge-base.sh | 3 +-
--
2.19.0
