On 10/17/2018 8:06 PM, brian m. carlson wrote:
On Wed, Oct 17, 2018 at 04:31:19PM +0200, Duy Nguyen wrote:
On Wed, Oct 17, 2018 at 12:44 AM brian m. carlson
<sandals@xxxxxxxxxxxxxxxxxxxx> wrote:
Honestly, anything in the .git directory that is not the v3 pack indexes
or the loose object file should be in exactly one hash algorithm. We
could simply just leave this value at 1 all the time and ignore the
field, since we already know what algorithm it will use.
In this particular case, I agree, but not as a general principle. It's
nice to have independence for fsck-like tools. I don't know if we have
a tool that simply validates commit-graph file format (and not trying
to access any real object). But for such a tool, I guess we can just
pass the hash algorithm from command line. The user would have to
guess a bit.
I'm going to drop this patch for now. I'll send a follow-up series
later which bumps the format version for this and the multi-pack index
and serializes them with the four-byte value. I probably should have
caught this earlier, but unfortunately I don't always have the time to
look at every series that hits the list.
We should coordinate before incrementing the version number. I was
working on making the file formats incremental (think split-index) but
couldn't come up with a way to do it without incrementing the file
format. It would be best to combine these features into v2 of each format.
Thanks,
-Stolee
