On Mon, Oct 15, 2018 at 6:14 AM Brendan Forster via GitGitGadget
<gitgitgadget@xxxxxxxxx> wrote:
> This config value is only used if http.sslBackend is set to "schannel",
> which forces cURL to use the Windows Certificate Store when validating
> server certificates associated with a remote server.
>
> This is only supported in cURL 7.44 or later.
> [...]
> Signed-off-by: Brendan Forster <github@xxxxxxxxxxxxxxxxxx>
> ---
> diff --git a/http.c b/http.c
> @@ -811,6 +818,16 @@ static CURL *get_curl_handle(void)
> + if (http_ssl_backend && !strcmp("schannel", http_ssl_backend) &&
> + !http_schannel_check_revoke) {
> +#if LIBCURL_VERSION_NUM >= 0x072c00
> + curl_easy_setopt(result, CURLOPT_SSL_OPTIONS, CURLSSLOPT_NO_REVOKE);
> +#else
> + warning("CURLSSLOPT_NO_REVOKE not applied to curl SSL options because\n"
> + "your curl version is too old (>= 7.44.0)");
This message is confusing. If your curl is too old, shouldn't the ">=" be a "<"?
> +#endif
> + }
