Junio C Hamano <gitster@xxxxxxxxx> writes: > SZEDER Gábor <szeder.dev@xxxxxxxxx> writes: > >> Most of our semantic patches in 'contrib/coccinelle/object_id.cocci' >> turn calls of SHA1-specific functions into calls of their >> corresponding object_id counterparts, e.g. sha1_to_hex() to >> oid_to_hex(). These semantic patches look something like this: >> >> @@ >> expression E1; >> @@ >> - sha1_to_hex(E1.hash) >> + oid_to_hex(&E1) >> >> and match the access to the 'hash' field in any data type, not only in >> 'struct object_id', and, consquently, can produce wrong >> transformations. > > Thanks, will queue. I ended up taking this as part of Brian's "the-hash-algo" series.
