Re: Mark Levedahl's gitk patches

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Paul Mackerras <paulus@xxxxxxxxx> writes:

> Mark Levedahl writes:
>
>> I found a bug in the highlight patch (the color picker updated the wrong 
>> panel in the chooser but did set the correct color), and updated the 
>> tab-stop patch to use a spin control to enforce entry of small integers 
>> only. As there is possible interest, I am sending the amended series.
>
> Ah.  I just pushed out a pile of patches to gitk.git including your
> three.  Could you do an incremental patch on top of that for me?

I took a look at differences between your gitk.git and what I
have.  It appears that our "proc readrefs" differ a bit.

Most notably, the global hash tagcontents is read when readrefs
run in the version I have, while gitk.git version fills it
lazily in showtag, where it is actually used.  Because you read
the refs using "show-ref -d", you do not need to do extra forks
to figure out the objects referred to by the tags in your code.

I think what you have is a lot better from interactive latency
point of view.  I'll take the version from gitk.git and push the
results out.


-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux