On 10/10/2018 9:50 PM, Jonathan Nieder wrote:
Hi,
Derrick Stolee wrote:
commit-reach.c | 4 +++-
t/t6600-test-reach.sh | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
I like this testing technique, and the test passes for me.
Except: if I put
CC = cc -m32
NO_OPENSSL = YesPlease
NO_CURL = YesPlease
in config.mak (the first line to force 32-bit pointers, the others
to avoid some dependencies on libs that I don't have 32-bit versions
of), then the test fails for me:
$ ./t6600-test-reach.sh -v -x -i
[...]
expecting success:
cp commit-graph-full .git/objects/info/commit-graph &&
run_and_check_trace2 can_all_from_reach_with_flag num_walked 19 input \
"test-tool reach can_all_from_reach"
++ cp commit-graph-full .git/objects/info/commit-graph
++ run_and_check_trace2 can_all_from_reach_with_flag num_walked 19 input 'test-tool reach can_all_from_r
each'
++ CATEGORY=can_all_from_reach_with_flag
++ KEY=num_walked
++ VALUE=19
++ INPUT=input
++ COMMAND='test-tool reach can_all_from_reach'
+++ pwd
++ GIT_TR2_PERFORMANCE='/usr/local/google/home/jrn/src/git/t/trash directory.t6600-test-reach/perf-log.t
xt'
++ test-tool reach can_all_from_reach
can_all_from_reach(X,Y):1
++ cat perf-log.txt
++ grep 'category:can_all_from_reach_with_flag key:num_walked value:19'
error: last command exited with $?=1
not ok 11 - can_all_from_reach:perf
#
# cp commit-graph-full .git/objects/info/commit-graph &&
# run_and_check_trace2 can_all_from_reach_with_flag num_walked 19 input \
# "test-tool reach can_all_from_reach"
#
When I cat perf-log.txt, I see
..category:can_all_from_reach_with_flag key:num_walked value:20
instead of the expected 19.
It is possible this is related to the sort-order problem reported and
fixed by Rene [1]. I'll look into it in any case.
[1]
https://public-inbox.org/git/dca35e44-a763-bcf0-f457-b8dab53815cf@xxxxxx/
