Hello, On large repositories with lots of tags - git wire protocol v2 fails to fetch shallow changes, it fails with error `pack has XXX unresolved deltas`. Unfortunately I didn't find easy way to reproduce it except cloning+fetching chromium repository, the way jenkins does. Reproduction steps: ``` $ git clone --mirror https://chromium.googlesource.com/chromium/src chromium Cloning into bare repository 'chromium'... remote: Sending approximately 12.66 GiB ... remote: Counting objects: 8523271, done remote: Finding sources: 100% (8399287/8399287) remote: Total 19829104 (delta 11897257), reused 19828780 (delta 11897257) Receiving objects: 100% (19829104/19829104), 20.45 GiB | 29.17 MiB/s, done. Resolving deltas: 100% (11897257/11897257), done $ mkdir chromium-test $ cd chromium-test $ git init Initialized empty Git repository in /home/arturas/.git/ $ git -c protocol.version=2 fetch --tags file://$(pwd)/../chromium/ +refs/heads/*:refs/remotes/origin/* --depth=1 remote: Enumerating objects: 4614683, done. remote: Counting objects: 100% (4614683/4614683), done. remote: Compressing objects: 100% (1556691/1556691), done. Receiving objects: 100% (4614683/4614683), 8.29 GiB | 24.71 MiB/s, done. remote: Total 4614683 (delta 3470249), reused 3989191 (delta 2923800) Resolving deltas: 100% (3470249/3470249), done. >From file:///home/arturas/chromium-test/../chromium * [new branch] ignore/bar -> origin/ignore/bar * [new branch] ignore/foo -> origin/ignore/foo * [new branch] infra/config -> origin/infra/config * [new branch] lkgr -> origin/lkgr * [new branch] master -> origin/master * [new tag] 10.0.601.0 -> 10.0.601.0 ... $ git -c protocol.version=2 fetch --tags file://$(pwd)/../chromium/ +refs/heads/*:refs/remotes/origin/* --depth=1 remote: Enumerating objects: 642969, done. remote: Counting objects: 100% (588314/588314), done. remote: Compressing objects: 100% (240564/240564), done. Receiving objects: 100% (571353/571353), 967.83 MiB | 10.52 MiB/s, done. remote: Total 571353 (delta 372206), reused 497895 (delta 310113) Resolving deltas: 99% (371726/372206), completed with 5582 local objects. fatal: pack has 480 unresolved deltas fatal: index-pack failed $ git --version git version 2.19.1 ``` No changes are needed in mirrored repository. Crash happens both with 2.18.0 and 2.19.1 git versions. Having repository locally is not required but reduces test runtime, you can quite reliably reproduce issue when fetching over net directly from chromium.orgbypassing mirroring step. -- Arturas Moskvinas
