Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: >> It also means that we no longer need the inet_pton() and inet_ntop() >> emulation, which is nice. > > Earlier in this series you add a: > > #if defined(_WIN32_WINNT) && _WIN32_WINNT >= 0x600 > ... > #endif > > Shouldn't that now be something like: > > #if defined(_WIN32_WINNT) > #if _WIN32_WINNT >= 0x600 > ... > #else > #error "You need at least Windows Vista to build Git!" > #endif > #endif > > Or do we catch users building on non-supported versions earlier somehow > (i.e. not just with a flood of compilation errors). That sounds like a reasonable thing to be curious about. > Both of the above are just questions I was curious about since I saw > your <nycvar.QRO.7.76.6.1810101502220.2034@xxxxxxxxxxxxxxxxx>, and > shouldn't bee seen as bumping this to "this needs a re-roll" or it > should be delayed in getting to master.
