On Wed, Oct 10, 2018 at 5:29 AM Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > On Tue, Oct 9, 2018 at 4:59 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > My inclination is to recommend to: > > > > (1) name the "show the current one" not "--current" but with some > > verb > > > > (2) display nothing when there is no current branch (i.e. detached > > HEAD) and without any error. > > Sensible suggestions. Also, please documentation any new option(s) in > Documentation/git-branch.txt. Sorry, I was expecting to see the documentation update in patch 1 and didn't notice that it was being done by patch 2. The reason I had that expectation is that a change of functionality and the documentation of that change are logically related, thus (usually) ought to be presented together. Therefore, when you re-roll, you may want to consider squashing the two patches into one.
