On Thu, Oct 04, 2018 at 05:05:37PM +0200, René Scharfe wrote: > Two new patches to avoid using oidset internals in fetch-pack: > > fetch-pack: factor out is_unmatched_ref() > fetch-pack: load tip_oids eagerly iff needed > > Unchanged patch: > > khash: factor out kh_release_* > > Unchanged, except it doesn't touch fetch-pack anymore: > > oidset: use khash > > A new patch, to reduce object text size: > > oidset: uninline oidset_init() I left a few responses to the fetch-pack changes. The rest of it all looks good to me. Certainly it's satisfying for the implementation-swap in patch 4 to be able to touch _only_ oidset.[ch]. -Peff
