Hi Ananya, On Thu, 4 Oct 2018, Ananya Krishna Maram wrote: > On Thu, 4 Oct 2018 at 20:56, Johannes Schindelin > <Johannes.Schindelin@xxxxxx> wrote: > > > > [... talking about the reason why a slash does not need to be escaped > > in a C string specifying a regular expression...] > > > > But it does not need to be escaped, when you specify the regular > > expression the way we do. And the way we specified it is really the > > standard when specifying regular expressions in C code, i.e. *without* the > > suggested backslash. > > Aha!. this makes total sense. I was thinking from a general regular expression > point of view. But I should be thinking from C point of view and how C > might interpret this newly submitted string. > This explanation is very clear. Thanks for taking time to reply to my > patch. From next time on, I will try to think from > git project's point of view. Of course! Thank you for taking the time to contribute this patch. Maybe you have another idea for a micro-project? Maybe there is something in Git that you wish was more convenient? Or maybe https://public-inbox.org/git/?q=leftoverbits has something that you would like to implement? Ciao, Johannes > > Thanks, > Ananya. > > > Ciao, > > Johannes > > > > > > > > Thanks, > > > Ananya. > > > > > > > Thanks, > > > > Johannes > > > > > > > > > --- > > > > > userdiff.c | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/userdiff.c b/userdiff.c > > > > > index f565f6731..f4ff9b9e5 100644 > > > > > --- a/userdiff.c > > > > > +++ b/userdiff.c > > > > > @@ -123,7 +123,7 @@ PATTERNS("python", "^[ \t]*((class|def)[ \t].*)$", > > > > > /* -- */ > > > > > "[a-zA-Z_][a-zA-Z0-9_]*" > > > > > "|[-+0-9.e]+[jJlL]?|0[xX]?[0-9a-fA-F]+[lL]?" > > > > > - "|[-+*/<>%&^|=!]=|//=?|<<=?|>>=?|\\*\\*=?"), > > > > > + "|[-+*\/<>%&^|=!]=|\/\/=?|<<=?|>>=?|\\*\\*=?"), > > > > > /* -- */ > > > > > PATTERNS("ruby", "^[ \t]*((class|module|def)[ \t].*)$", > > > > > /* -- */ > > > > > -- > > > > > 2.17.1 > > > > > > > > > > > > > >
