On 02/10/2018 20:08, Stefan Beller wrote: > On Tue, Oct 2, 2018 at 10:55 AM Phillip Wood <phillip.wood@xxxxxxxxxxxx> wrote: >> >> From: Phillip Wood <phillip.wood@xxxxxxxxxxxxx> >> >> Don't duplicate the indentation string if we're not going to use it. >> This was found with asan. > > Makes sense, > > Thanks, > Stefan > > With compute_ws_delta growing bigger here (and having only one caller), > I wonder if we want to pass 'match' instead of match->es (and pmb_nr), > such that the function can also take care of > pmb[pmb_nr++].match = match; Wouldn't we still need to increment pmb_nr in the caller though, in which case I'm not sure it saves much. > Then the function is not a mere compute_ws_delta, but a whole > setup_new_pmb(...) thing. Undecided. >
