On Fri, Sep 28, 2018 at 9:55 AM Taylor Blau <me@xxxxxxxxxxxx> wrote: > On Thu, Sep 27, 2018 at 09:49:36PM -0700, Stephen P. Smith wrote: > > When updating the collect and print functions, it was found that > > status variables were initialized in the collect phase and some > > variables were later freed in the print functions. > > Nit: I think that in the past Eric Sunshine has recommended that I use > active voice in patches, but "it was found" is passive. > > I tried to find the message that I was thinking of, but couldn't, so > perhaps I'm inventing it myself ;-). > > I'm CC-ing Eric to check my judgement. You're probably thinking of "imperative mood" (and perhaps [1]), which this commit message already uses when it says "Move the..." and "Create a new function..." (in the couple paragraphs following the part you quoted). > > Move the status state structure variables into the status state > > structure and populate them in the collect functions. > > > > Create a new funciton to free the buffers that were being freed in the s/funciton/function/ > > print function. Call this new function in commit.c where both the > > collect and print functions were being called. [1]: https://public-inbox.org/git/CAPig+cTozduqSAxh+w4H85m7en72Yo09asdx+1KSTswqbnBr4w@xxxxxxxxxxxxxx/
