On Sat, Sep 29, 2018 at 10:39:54AM -0700, Junio C Hamano wrote:
> Suppose "git foo" is aliased to a command "git bar".
>
> The best case is when "git bar -h" knows that it is asked to give us
> a short usage. We get "foo is aliased to bar" followed by the short
> usage for "bar" and everything is visible above the shell prompt
> after all that happens.
>
> The second best case is when "git bar" simply does not support "-h"
> but actively notices an unknown option on the command line to give
> the usage message. We see "foo is aliased to bar" followed by "-h
> is an unknown option; supported options are ..." and everything is
> visible above the shell prompt after all that happens.
Right, these are the ones we hope for.
> The worst case is when "git bar" supports or ignores "-h" and
> produces reams of output. Sending the "aliased to" message to the
> standard error means that it is scrolled out when the output is
> done, or lost even when "git foo -h | less" attempts to let the
> reader read before the early part of the output scrolls away.
This is the "who-knows-what" case I meant here:
>> It is a little funny, I guess, if you have a script which doesn't
>> respond to "-h", because you'd get our "foo is aliased to git-bar"
>> message to stderr, followed by who-knows-what. But as long as it's to
>> stderr (and not stdout), I think it's not likely to _break_ anything.
And I think this has to be stderr. We're polluting the output of the
aliased command with our extra message, so we have two choices:
1. Pollute stderr, and risk copious stdout (or a pager) scrolling it
off the screen.
2. Pollute stdout, at which point our message may be confused as part
of the actual output of the command (and that may not even be
immediately noticed if it is passed through a shell pipeline or
into a file).
Choice (2) seems like a regression to me. Choice (1) is unfortunate in
some cases, but is no worse than today's behavior.
(Obviously I'm not including choices like not running the sub-command at
all, but I think that would be even worse).
> Even the first two "better" cases share the same glitch if the "foo
> is aliased to bar" goes to the standard error output. Parse-options
> enabled commands tend to show a long "-h" output that you would need
> to say "git grep -h | less", losing the "aliased to" message.
>
> At least it seems to me an improvement to use standard output,
> instead of standard error, for the alias information.
...so I'd disagree with this.
> In practice, however, what the command that "git foo" is aliased to
> does when given "-h" is probably unknown (because the user is asking
> what "git foo" is in the first place), so perhaps I am worried too
> much. When the user does not know if the usage text comes to the
> standard output or to the standard error, and if the usage text is
> very long or not, they probably would learn quickly that the safest
> thing to do is to
>
> $ git unknown-command -h >&2 | less
>
> And at that point, it does not matter which between the standard
> output and the standard error streams we write "unknown-command is
> aliased to ...".
Yeah. I think if "git foo -h" produces a bunch of output you didn't
expect, then "git help foo" or "git foo --help" may be the next thing
you reach for. That's not so different than running the command even
without any aliases involved.
-Peff
