Stefan Beller <sbeller@xxxxxxxxxx> writes: > So let's format strbuf.h in a way that we'd like to see: > * omit the extern keyword from function declarations OK > * name all parameters (usually the parameters are obvious from its type, > but consider exceptions like > `int strbuf_getwholeline_fd(struct strbuf *, int, int);` I am mildly against giving names to obvious ones.