On 9/28/2018 6:01 AM, SZEDER Gábor wrote:
On Tue, Sep 18, 2018 at 11:29:35PM +0000, Ben Peart wrote:
diff --git a/t/README b/t/README
index 56a417439c..47165f7eab 100644
--- a/t/README
+++ b/t/README
@@ -319,6 +319,10 @@ GIT_TEST_OE_DELTA_SIZE=<n> exercises the uncommon pack-objects code
path where deltas larger than this limit require extra memory
allocation for bookkeeping.
+GIT_TEST_FSMONITOR=$PWD/t7519/fsmonitor-all exercises the fsmonitor
+code path for utilizing a file system monitor to speed up detecting
+new or changed files.
Here you tell us to set GIT_TEST_FSMONITOR to an absolute path, and we
are good to go.
diff --git a/t/t7519-status-fsmonitor.sh b/t/t7519-status-fsmonitor.sh
index 756beb0d8e..d77012ea6d 100755
--- a/t/t7519-status-fsmonitor.sh
+++ b/t/t7519-status-fsmonitor.sh
@@ -8,7 +8,7 @@ test_description='git status with file system watcher'
# To run the entire git test suite using fsmonitor:
#
# copy t/t7519/fsmonitor-all to a location in your path and then set
-# GIT_FSMONITOR_TEST=fsmonitor-all and run your tests.
+# GIT_TEST_FSMONITOR=fsmonitor-all and run your tests.
But this old comment is different, suggesting copying that script to
our $PATH.
I prefer your instructions above, because it's only a single step,
and, more importantly, it won't pollute my $PATH. I think this
comment should be updated to make the advices in both places
consistent. Or perhaps even removed, now that all GIT_TEST variables
are documented in the same place?
I prefer the suggestion to simply remove this text from the test script
now that there is documentation for it in the t/README file.
