On Fri, Sep 28, 2018 at 02:48:43AM +0200, SZEDER Gábor wrote: > Junio, > > On Thu, Sep 27, 2018 at 02:44:30PM +0200, SZEDER Gábor wrote: > > diff --git a/t/t1701-racy-split-index.sh b/t/t1701-racy-split-index.sh > > new file mode 100755 > > index 0000000000..ebde418d7e > > --- /dev/null > > +++ b/t/t1701-racy-split-index.sh > > @@ -0,0 +1,218 @@ > > +#!/bin/sh > > + > > +# This test can give false success if your machine is sufficiently > > +# slow or all trials happened to happen on second boundaries. > > + > > +test_description='racy split index' > > + > > +. ./test-lib.sh > > + > > +test_expect_success 'setup' ' > > + # Only split the index when the test explicitly says so. > > + sane_unset GIT_TEST_SPLIT_INDEX GIT_FSMONITOR_TEST && > > Please note that this patch adds another use of the environment > variable GIT_FSMONITOR_TEST, while the topic 'bp/rename-test-env-var' > is about to rename that variable to GIT_TEST_FSMONITOR. Hang on for a sec. I unset GIT_FSMONITOR_TEST in this test, because I saw that 't1700-split-index.sh' unsets it, and I just followed suit. But come to think of it, t1700 has to unset it, because some of its tests check the index's SHA-1 checksum, and the FSMN extension would interfere with that, of course. However, that's not an issue for t1701, because none of its tests care about the index's checksum, so unsetting GIT_FSMONITOR_TEST is actually unnecessary here... unless it could have other side effects that I'm not aware of.
