2018-09-26 12:52 GMT+03:00 Martin Ågren <martin.agren@xxxxxxxxx>:
> On Wed, 26 Sep 2018 at 11:00, Alexander Pyhalov <apyhalov@xxxxxxxxx> wrote:
>> As for sign-off, do I understand correctly that you just want to know
>> that I'm the original author of the code? Yes, it's so.
>
> Right. Plus that you agree that the code (the commit) may be
> redistributed basically forever.
I'm fine with it.
> I came up with the following commit message. What do you think about it?
>
> t7005-editor: quote filename to fix whitespace-issue
>
> Commit 4362da078e (t7005-editor: get rid of the SPACES_IN_FILENAMES
> prereq, 2018-05-14) removed code for detecting whether spaces in
> filenames work. Since we rely on spaces throughout the test suite
> ("trash directory.t1234-foo"), testing whether we can use the filename
> "e space.sh" was redundant and unnecessary.
>
> In simplifying the code, though, the commit introduced a regression around
> how spaces are handled, not in the /name/ of the script, but /in/ the
> script itself. The editor-script created looks like this:
>
> echo space >$1
>
> We will try to execute something like
>
> echo space >/foo/t/trash directory.t7005-editor/.git/COMMIT_EDITMSG
>
> Most shells seem to be able to figure out that the filename doesn't end
> with "trash" but continues all the way to "COMMIT_EDITMSG", but at least
> one shell chokes on this.
>
> Make sure that the editor-script quotes "$1".
>
Looks fine. Thanks.
--
С уважением,
Александр Пыхалов
