On Fri, Sep 21 2018, Stefan Beller wrote: > +/* > + * Apply want to each entry in array, retaining only the entries for > + * which the function returns true. Preserve the order of the entries > + * that are retained. > + */ > +void oid_array_filter(struct oid_array *array, > + for_each_oid_fn want, > + void *cbdata); > + > #endif /* SHA1_ARRAY_H */ The code LGTM, but this comment should instead be an update to the API docs, see my recent 5cc044e025 ("get_short_oid: sort ambiguous objects by type, then SHA-1", 2018-05-10) for an addition of a new function to this API where I added some new docs.