On Fri, Sep 21, 2018 at 08:05:27AM -0700, Derrick Stolee via GitGitGadget wrote: > From: Derrick Stolee <dstolee@xxxxxxxxxxxxx> > > The can_all_from_reach_with_flag() method uses 'assign_flag' as a > value we can use to mark objects temporarily during our commit walk. > The intent is that these flags are removed from all objects before > returning. However, this is not the case. > > The 'from' array could also contain objects that are not commits, and > we mark those objects with 'assign_flag'. Add a loop to the 'cleanup' > section that removes these markers. > > Also, we forgot to free() the memory for 'list', so add that to the > 'cleanup' section. Urgh, ignore most of my response to patch 1, then. I saw there was a patch 2, but thought it was just handling the free(). The flag-clearing here makes perfect sense. -Peff
