On Fri, Sep 21, 2018 at 03:06:43PM -0700, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > There's no extension necessary; these should already affect upload-pack > > as well. I agree transport.* would cover both upload-pack and > > receive-pack. If we extend it to check_everything_connected(), would it > > make sense as part of transport.*, too? > > > > I dunno. I guess I could see an argument either way. > > Sorry but I do not quite follow. Are you saying that something that > covers check-everything-connected would the result be too wide to > fit inside transport.*? or something that does not cover > check-everything-connected falls short of transport.*? Or something > else? Either way, core.* is way too wide for what this hook does, I > would think. I was suggesting that check_everything_connected() is not strictly transport-related, so would be inappropriate for transport.*, and we'd need a more generic name. And my "either way" was that I could see an argument that it _is_ transport related, since we only call it now when receiving a pack. But that doesn't have to be the case, and certainly implementing it with "rev-list --alternate-refs" muddies that considerably. I agree that core.* is kind of a kitchen sink, but I'm not sure that's all that bad. Is "here is how Git finds refs in an alternate" any more or less core than "here is how Git invokes ssh"? -Peff
