On Thu, Sep 20, 2018 at 1:47 PM <frederik@xxxxxxx> wrote: > On Thu, Sep 20, 2018 at 06:23:03PM +0200, Duy Nguyen wrote: > > On Wed, Sep 19, 2018 at 03:59:58PM -0700, Junio C Hamano wrote: > > > > @@ -23,7 +26,7 @@ OPTIONS > > > > > > > > --mode=<mode>:: > > > > Specify layout mode. See configuration variable column.ui for option > > > > - syntax. > > > > + syntax (in git-config(1)). > > > > I think we usually link to other commands with "linkgit", like > > linkgit:git-config[1] > > Thank you, then do I edit the patch and resubmit as PATCH v2 with the > message ID and all that? Editing the patch directly is not recommended. More typical would be to use "git rebase -i" and/or "git commit --amend" to make changes to the commits themselves (that is, rewrite history), taking review comments into account (and generally polishing the changes). Once the edits are complete, re-generate the patches with git-format-patch and re-send the entire series as v2 with git-send-email (or some people skip git-format-patch and go directly to git-send-email to both format and send the patches as one step). You can use the -v option of git-format-patch to mark the series as v2. When sending v2 via git-send-email, you can use the --in-reply-to option with the message ID of the v1 cover letter to tie the re-roll to the original. (The message ID of the v1 cover letter is "20180919201231.609-1-frederik@xxxxxxx".)
