Re: [PATCH 1/9] Makefile: add a hdr-check target

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> writes:

> Yes, this was one of my first concerns (I even asked Elijah what
> compiler options he used), but I was getting useful results without
> passing CFLAGS, so I just ignored that issue ... :-D
> ...
> Indeed. This bothered me as well. The 'compat' directory does not
> follow the 'usual pattern' of the main headers and is particularly
> sensitive to the lack of various -DMACROs. I had initially included
> _all_ sub-directories in the 'exclude list' (to follow what Elijah
> had done), but then removed one at a time ...
>
> I am open to suggestions for improvements. ;-)

Perhaps it is sufficient to add a mention of these two issues in log
message and an in-code comment nearby the .hco rule in Makefile, so
that people can come back later to discover what design choice we
made (i.e. "without worrying about these two issues, we are getting
useful enough results, so we decided it is OK at least for now not
to worry about them").

Thanks.



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux