Re: [PATCH 9/9] commit-reach.h: add missing declarations (hdr-check)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/18/2018 8:15 PM, Ramsay Jones wrote:
Signed-off-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx>
---
  commit-reach.h | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/commit-reach.h b/commit-reach.h
index 7d313e2975..f41d8f6ba3 100644
--- a/commit-reach.h
+++ b/commit-reach.h
@@ -1,12 +1,13 @@
  #ifndef __COMMIT_REACH_H__
  #define __COMMIT_REACH_H__
+#include "commit.h"
  #include "commit-slab.h"
-struct commit;
  struct commit_list;
-struct contains_cache;

Interesting that you needed all of commit.h here, and these 'struct commit' and 'struct contains_cache' were not enough. Was there a reason you needed the entire header file instead of just adding a missing struct declaration?

  struct ref_filter;
+struct object_id;
+struct object_array;
struct commit_list *get_merge_bases_many(struct commit *one,
  					 int n,

These look like standard inclusions. Thanks!



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux