Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes: > Commit b0db704652 (pathspec: allow querying for attributes - > 2017-03-13) adds new pathspec magic 'attr' but only with > match_pathspec(). "git add" has some pathspec related code that still > does not know about 'attr' and will bail out: > > $ git add ':(attr:foo)' > fatal: BUG:dir.c:1584: unsupported magic 40 > > A better solution would be making this code support 'attr'. But I > don't know how much work is needed (I'm not familiar with this new > magic). For now, let's simply reject this magic with a friendlier > message: > > $ git add ':(attr:foo)' > fatal: :(attr:foo): pathspec magic not supported by this command: 'attr' > > Reported-by: smaudet@xxxxxxxxxxxxxxxxxx > Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> > --- > Since Brandon is currently unreachable, let's do this for now. Thanks. This certainly make it better than the status quo.