Hi Ramsay, On Tue, Sep 18, 2018 at 5:09 PM Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> wrote; > This series follows on from a quick "just before bedtime" exercise > recently[1]. The new 'hdr-check' target essentially automates what > Elijah did by hand. Cool, thanks for doing this. I believe I only tried to directly check the toplevel header files (any fixes I made to headers in subdirectories were just due to their indirect inclusion), so it's not surprising to see that you needed to fix up some headers in subdirectories. It is slightly surprising to me that we've already gained 6 cases of toplevel header files that needed fixes; that suggests this hdr-check is even more useful than I would have suspected. The Make-fu in patch 1 is beyond the make I know, but the other patches are all pretty simple and look good to me.
