On Mon, Sep 17, 2018 at 02:45:55PM -0700, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > Yes, I think sorting the expect file would work fine. I'm OK with that, > > or just leaving a comment. The comment has the bonus that it does not > > cost an extra process at runtime. I'd probably use a sort if we expected > > the list to be long and complicated, since it makes life easier on a > > future developer. But since there are only 2 lines, I don't think it's a > > big deal either way (or even just leaving it as-is without a comment is > > probably OK). > > Let's have "| sort" if only for its documentation value. That way > we do not have to remember the list must be sorted. OK, though... > diff --git a/t/t5551-http-fetch-smart.sh b/t/t5551-http-fetch-smart.sh > index 771f36f9ff..d13b993201 100755 > --- a/t/t5551-http-fetch-smart.sh > +++ b/t/t5551-http-fetch-smart.sh > @@ -206,7 +206,7 @@ test_expect_success 'dumb clone via http-backend respects namespace' ' > cat >cookies.txt <<EOF > 127.0.0.1 FALSE /smart_cookies/ FALSE 0 othername othervalue > EOF > -cat >expect_cookies.txt <<EOF > +cat <<EOF | sort >expect_cookies.txt This can be spelled: sort >expect_cookies.txt <<EOF can't it? Then we do not even incur the extra process. :) -Peff
