Junio C Hamano wrote: > Jonathan Nieder <jrnieder@xxxxxxxxx> writes: >> I'd rather that we revert this change altogether. I have nothing >> against a convenient command to do this kind of non build related >> cleanup, but it shouldn't be spelled as "make clean". > > OK, let's do this for now as I wanted to merge the remainder to > 'master' today. > > -- >8 -- > Subject: Revert "doc/Makefile: drop doc-diff worktree and temporary files on "make clean"" > > This reverts commit 6f924265a0bf6efa677e9a684cebdde958e5ba06, which > started to require that we have an executable git available in order > to say "make clean", which gives us a chicken-and-egg problem. > > Having to have Git installed, or be in a repository, in order to be > able to run an optional "doc-diff" tool is fine. Requiring either > in order to run "make clean" is a different story. > > Reported by Jonathan Nieder <jrnieder@xxxxxxxxx>. > --- > Documentation/Makefile | 1 - > 1 file changed, 1 deletion(-) Does this want a sign-off? In any event, this matches what I had applied in Debian[1] and is Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx> Thanks, Jonathan [1] http://repo.or.cz/git/debian.git/blob/refs/heads/debian-experimental:/debian/patches/0002-Revert-doc-Makefile-drop-doc-diff-worktree-and-tempor.diff aka http://repo.or.cz/git/debian.git/blob/9872ab1d87634a9288266de290571928e5b9346f:/debian/patches/0002-Revert-doc-Makefile-drop-doc-diff-worktree-and-tempor.diff
