Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes: > The current naming convention for 'struct repository *' is 'r' for > temporary variables or arguments. I did not notice this. Since we're > updating blame.c again in the next patch, let's fix this. It is likely that we end up having to refer to an in-core repository object in many places, so giving a short-and-sweet 'r' to it makes quite a lot of sense. One thing we may want to do as preparation related to this effort is to sweep the codebase to make sure we do not use 'r' as a variable that refers to anything other than an in-core repository object. Thanks.