Junio C Hamano <gitster@xxxxxxxxx> writes:
> Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:
>
>> - set_author_env=`git show -s --pretty=raw --encoding="$encoding" "$use_commit" |
>> - LANG=C LC_ALL=C sed -ne "$pick_author_script"`
>> - eval "$set_author_env"
>> ...
>> + eval $(get_author_ident_from_commit "$use_commit")
>
> Are you sure about this part of the change? I suspect that you
> are losing IFS by not dq'ing the argument you give to the eval.
>
> ...
If you care about your data in your variable and do not want
word-splitting at $IFS to happen, you should always dq your
variable. A quick rule of thumb is that the only place that you
can get away by not quoting is straight assignment to another
variable, like so:
var='a b c '
another=$var ;# another="$var" is fine but unnecessary.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
