On Tue, Sep 11, 2018 at 4:26 PM Derrick Stolee via GitGitGadget <gitgitgadget@xxxxxxxxx> wrote: > In es/format-patch-rangediff, we added a '--range-diff' option to > git-format-patch to automatically add a range-diff. We also added an option > to write the diff as commentary to a single patch submission. However, this > check was not tested. It was an intentional (though unjustified) oversight. Thanks for working on this. > I discovered this test gap by running 'make coverage-test coverage-report' > on 'next' and then comparing the uncovered lines with those in the diff > between 'master' and 'next'. I have a script that automates this process, > and I'm still working on polishing it. Interesting. Does your script detect that the --creation-factor option added by patch 13/14 [1] also lacks a test? (I'm not necessarily suggesting adding a test at the moment. Even Dscho's git-range-diff series doesn't have a test for "creation factor", so it wouldn't necessarily make sense to add a test only for the git-format-patch case. Instead, we'd want, at some point, to add tests covering both git-range-diff and git-format-patch.) [1]: https://public-inbox.org/git/20180722095717.17912-14-sunshine@xxxxxxxxxxxxxx/
