On Mon, Sep 10, 2018 at 08:08:35PM -0700, Stefan Beller wrote: > > So the choice being offered are: > > > > (0) take 2/2 only, keeping zero unused helper. > > (1) take 1/2 only, keeping two unused helpers. > > (2) do nothing, keeping the simple unused helper we had from the > > beginning of time. > > (3) take 1/2 and 2/2, replacing one simple unused helper with > > another unused helper that is more complex and capable. > [...] > > Yes, I think (0) is the way to go, actually. > > I wrote patch 1/2 to show Peff and you to prove otherwise that I am > not contributing "only grudgingly". I am perfectly happy with 0. But for reference, your new trace helper looks completely reasonable from a quick view. Perhaps we can let it live on in the list archive, and somebody may find a good use for it in the future (though there is a significant chance that they would not think to search the archive -- it could even be of value to commit and revert it so that they find it in "git log", but that may be getting pretty hypothetical). -Peff
