On Tue, Sep 11, 2018 at 12:31 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Junio C Hamano <gitster@xxxxxxxxx> writes: > > > Stefan Beller <sbeller@xxxxxxxxxx> writes: > > > >> The helper function stayed unused for 3 years. A removal of that function > > > > I think it stayed unused for more than that before the previous > > proposal to remove it was written (I do not bother going back to my > > earlier message that identified which exact commit this was > > introduced at). It has stayed that way for 3 more years since then. > > > >> was proposed before[1], but now time has proven we really do not need the > >> function. > >> > >> [1] https://public-inbox.org/git/1421343725-3973-1-git-send-email-kuleshovmail@xxxxxxxxx/ > >> Signed-off-by: Stefan Beller <sbeller@xxxxxxxxxx> > > > > I'll add a blank line before the sign-off. Is this an example that > > our "where is the existing trailer?" code misbehaving? > > I am still curious about this one. No, it's me who is misbehaving. ;-) While I do have format.signoff set, such that I never forget to sign off on a patch, I have the habit to sign it off manually, in git-gui while editing the commit message so I can see the whole message. > In any case, I've reworded the above around "3 years". > > string-list: remove unused function print_string_list > > A removal of this helper function was proposed 3 years ago [1]; the > function was never used since it was introduced in 2006 back then, > and there is no new callers since. Now time has proven we really do > not need the function. > > [1] https://public-inbox.org/git/1421343725-3973-1-git-send-email-kuleshovmail@xxxxxxxxx/ > > Signed-off-by: Stefan Beller <sbeller@xxxxxxxxxx> > Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx> > > Thanks. Thanks for rewording it. Stefan
