On Mon, Sep 10, 2018 at 02:22:21PM -0700, Jonathan Nieder wrote:
> Thanks. I am wondering if we should go all the way and do
>
> ssize_t val;
> const char *str = getenv("CONTENT_LENGTH");
>
> if (!str || !*str)
> return 0;
> if (!git_parse_ssize_t(str, &val))
> die(...);
> return val;
>
> That would match the RFC, but it seems to make t5510-fetch.sh hang,
> right after
>
> ok 165 - --negotiation-tip understands abbreviated SHA-1
>
> When I run with -v -i -x, it stalls at
>
> ++ git -C '/usr/local/google/home/jrn/src/git/t/trash directory.t5510-fetch/httpd/www/server' tag -d alpha_1 alpha_2 beta_1 beta_2
> Deleted tag 'alpha_1' (was a84e4a9)
> Deleted tag 'alpha_2' (was 7dd5cf4)
> Deleted tag 'beta_1' (was bcb5c65)
> Deleted tag 'beta_2' (was d3b6dcd)
> +++ pwd
> ++ GIT_TRACE_PACKET='/usr/local/google/home/jrn/src/git/t/trash directory.t5510-fetch/trace'
> ++ git -C client fetch --negotiation-tip=alpha_1 --negotiation-tip=beta_1 origin alpha_s beta_s
>
> Do you know why?
Yes. :)
It's due to this comment in the patch you are replying to:
+ if (!str) {
+ /*
+ * RFC3875 says this must mean "no body", but in practice we
+ * receive chunked encodings with no CONTENT_LENGTH. Tell the
+ * caller to read until EOF.
+ */
+ val = -1;
-Peff
