Re: [PATCH v2 10/11] builtin rebase: only store fully-qualified refs in `options.head_name`

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



SZEDER Gábor <szeder.dev@xxxxxxxxx> writes:

>>  		} else {
>> -			options.head_name = xstrdup("detached HEAD");
>> +			free(options.head_name);
>> +			options.head_name = NULL;
>
> Please use FREE_AND_NULL(options.head_name) here.

Good; did contrib/coccinelle/free.cocci catch this?

>
>>  			branch_name = "HEAD";
>>  		}
>>  		if (get_oid("HEAD", &options.orig_head))
>> -- 
>> gitgitgadget
>> 



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux