On Wed, Sep 5, 2018 at 12:18 PM Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: > > Hi, > > Stefan Beller wrote: > > > This is the continuation of f2d48994dc1 (submodule.c: submodule_move_head > > works with broken submodules, 2017-04-18), which tones down the case of > > "broken submodule" in case of a missing git directory of the submodule to > > be only a warning. > > > > Signed-off-by: Stefan Beller <sbeller@xxxxxxxxxx> > > --- > > submodule.c | 16 ++++++++++++++++ > > t/t2013-checkout-submodule.sh | 2 +- > > 2 files changed, 17 insertions(+), 1 deletion(-) > > I don't understand what workflow this is a part of. > > If the submodule is missing, shouldn't we make it non-missing instead > of producing a partial checkout that doesn't build? No. checkout and friends do not want to touch the network (unless we are in a partial clone world; that is the user is fully aware that commands can use the network at totally unexpected times) So for that, all we can do is better error messages. Stefan
