On Wed, Sep 5, 2018 at 10:46 AM Derrick Stolee via GitGitGadget <gitgitgadget@xxxxxxxxx> wrote: > Add tests that check corrupted headers in a few ways: > [...] > Signed-off-by: Derrick Stolee <dstolee@xxxxxxxxxxxxx> > --- > diff --git a/t/t5319-multi-pack-index.sh b/t/t5319-multi-pack-index.sh > @@ -154,6 +154,51 @@ test_expect_success 'verify multi-pack-index success' ' > +corrupt_midx_and_verify() { > + POS=$1 > + DATA="${2:-\0}" > + OBJDIR=$3 > + GREPSTR="$4" If you happen to re-roll, perhaps make these assignments part of the &&-chain to protect against someone coming along some day an inserting code before them without realizing that the &&-chain is broken. > + FILE=$OBJDIR/pack/multi-pack-index && > + chmod a+w $FILE && > + test_when_finished mv midx-backup $FILE && > + cp $FILE midx-backup && > + printf "$DATA" | dd of="$FILE" bs=1 seek="$POS" conv=notrunc && > + test_must_fail git multi-pack-index verify --object-dir=$OBJDIR 2>test_err && > + grep -v "^+" test_err >err && > + test_i18ngrep "$GREPSTR" err > +}