On Wed, Sep 5, 2018 at 7:46 AM Derrick Stolee via GitGitGadget <gitgitgadget@xxxxxxxxx> wrote: > > From: Derrick Stolee <dstolee@xxxxxxxxxxxxx> > > The final check we make while loading a multi-pack-index is that > the packfile names are in lexicographical order. Make this error > be a die() instead. What is the advantage of having a die() here? Would the midx work under normal operation when not sorted correctly? This sounds like a hack for easy testability in this context, so could you clarify why this helps the regular user? Thanks, Stefan