On Tue, Sep 4, 2018 at 11:06 AM Matthew DeVore <matvore@xxxxxxxxxx> wrote: > > I made the following changes since v6 of the patchset: > - (suggested by Duy Nguyen) add a new commit which replaces uses of die() with > BUG() in list-objects-filter.c wherever it corresponds to a coding error. > - Replace die() with BUG() in new code. > - Replace test_line_count = 0 with test_must_be_empty in new tests since the > trend seems to be, based on other RFCs in progress, that we are standardizing > on that phraseology. See: > https://public-inbox.org/git/20180819215725.29001-1-szeder.dev@xxxxxxxxx/ > > As asked in the last "What's cooking in git.git" post, the status of this patch > is: > - The original reviewer, Jonathan Tan, is on vacation and will be back later > this week. > - Stefan Beller has been reviewing the patchset in Jonathan's absence, and > stated that it's a good read despite not being familiar with the code: > https://public-inbox.org/git/CAGZ79kaWcGbyc2S5gOCU7NdvT4fN46jq4xK9MvTLAFBGhyuo2A@xxxxxxxxxxxxxx/ and this still holds. Thanks, Stefan
