On Wed, Aug 29, 2018 at 2:49 PM Derrick Stolee via GitGitGadget <gitgitgadget@xxxxxxxxx> wrote: > > The commit-graph (and multi-pack-index) features are optional data > structures that can make Git operations faster. Since they are optional, we > do not enable them in most Git tests. The commit-graph is tested in > t5318-commit-graph.sh (and t6600-test-reach.sh in ds/reachable), but that > one script cannot cover the data shapes present in the rest of the test > suite. > > This patch introduces a new test environment variable, GIT_TEST_COMMIT_GRAPH > . Similar to GIT_TEST_SPLIT_INDEX, it enables the commit-graph and writes it > with every git commit command. Thanks, Duy, for pointing out this direction > [1]. Any reason to not add this new flag in ci/run-build-and-tests.sh (which is used by Travis)? I see your note about VSTS but I don't see why it has to be exclusive to VSTS. > A few tests needed to be modified. These are the same tests that were > mentioned in my previous example patch [2]. Thanks, Eric, for providing the > correct way to override the settings [3]. > > When this merges down, I'll create a CI build in VSTS that runs the test > suite with this option enabled. -- Duy
