On Wed, Aug 29, 2018 at 12:56:36AM +0000, brian m. carlson wrote:
> We transform various object IDs into all-zero object IDs for comparison.
> Adjust the length as well so that this works for all hash algorithms.
>
> Signed-off-by: brian m. carlson <sandals@xxxxxxxxxxxxxxxxxxxx>
> ---
> t/t0027-auto-crlf.sh | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/t/t0027-auto-crlf.sh b/t/t0027-auto-crlf.sh
> index beb5927f77..0f1235d9d1 100755
> --- a/t/t0027-auto-crlf.sh
> +++ b/t/t0027-auto-crlf.sh
> @@ -14,11 +14,13 @@ compare_files () {
> compare_ws_file () {
> pfx=$1
> exp=$2.expect
> + tmp=$2.tmp
> act=$pfx.actual.$3
> - tr '\015\000abcdef0123456789' QN00000000000000000 <"$2" >"$exp" &&
> + tr '\015\000abcdef0123456789' QN00000000000000000 <"$2" >"$tmp" &&
> tr '\015\000abcdef0123456789' QN00000000000000000 <"$3" >"$act" &&
> + sed -e "s/0000*/$ZERO_OID/" "$tmp" >"$exp" &&
> test_cmp "$exp" "$act" &&
> - rm "$exp" "$act"
> + rm "$exp" "$act" "$tmp"
> }
>
> create_gitattributes () {
I only managed to review the changes in t0027.
Out of interest: why do we use a "tmp" file here?
Would it make more sense to chain the 'tr' with 'sed' and skip the
tmp file ?
tr '\015\000abcdef0123456789' QN00000000000000000 <"$2" |
sed -e "s/0000*/$ZERO_OID/" >"$exp" &&
Yes, we will loose the exit status of 'tr', I think.
How important is the exit status ?
I don't know, hopefully someone with more experience/knowledge
about shell scripting can help me out here.
