On Fri, Aug 31 2018, Stephen P. Smith wrote: > diff --git a/t/t7501-commit.sh b/t/t7501-commit.sh > index 4cae92804..810d4cea7 100755 > --- a/t/t7501-commit.sh > +++ b/t/t7501-commit.sh > @@ -99,12 +99,12 @@ test_expect_success '--dry-run with stuff to commit returns ok' ' > git commit -m next -a --dry-run > ' > > -test_expect_failure '--short with stuff to commit returns ok' ' > +test_expect_success '--short with stuff to commit returns ok' ' > echo bongo bongo bongo >>file && > git commit -m next -a --short > ' > > -test_expect_failure '--porcelain with stuff to commit returns ok' ' > +test_expect_success '--porcelain with stuff to commit returns ok' ' > echo bongo bongo bongo >>file && > git commit -m next -a --porcelain This commit is not OK and needs to be folded into later commits. It makes the test suite fail until (presumably, haven't reviewed the rest) a later commit. The tests must always pass, otherwise someone bisecting will trip up over this commit.
