On Wed, Aug 29, 2018 at 08:41:36AM -0400, Derrick Stolee wrote: > On 8/28/2018 8:58 PM, brian m. carlson wrote: > > Instead of using hard-coded constants for object sizes, use > > the_hash_algo to look them up. In addition, use a function call to look > > up the object ID version and produce the correct value. > > The C code in this patch looks good to me. The only issue is that I predict > failure in the 'git commit-graph verify' tests in t5318-commit-graph.sh. > Squashing in this commit should help (assuming that test_oid works, it > doesn't at my current branch): Yeah, this is a separate series not based on the other one. If I finally submit this after the other series lands, I'll squash that change in. Thanks for the patch. -- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204
Attachment:
signature.asc
Description: PGP signature
