On Wed, Aug 29, 2018 at 2:09 PM Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: > > Jeff King wrote: > > On Tue, Aug 28, 2018 at 02:35:25PM -0700, Stefan Beller wrote: > > >> Yeah, then let's just convert '/' with as little overhead as possible. > > > > Do you care about case-folding issues (e.g., submodules "FOO" and "foo" > > colliding)? > > > > I'm OK if the answer is "no", but if you do want to deal with it, the > > time is probably now. > > Have we rejected the config approach? I did not reject that approach, but am rather waiting for patches. ;-) > I really liked the attribute of > not having to solve everything right away. I'm getting scared that > we've forgotten that goal. Eh, sorry for side tracking this issue. I am just under the impression that the URL encoding is not particularly good for our use case as it solves just one out of many things, whereas the one thing (having no slashes) can also be solved in an easier way. > It mixes well with Stefan's idea of setting up a new .git/submodules/ > directory. We could require that everything in .git/submodules/ have > configuration (or that everything in that directory either have > configuration or be the result of a "very simple" transformation) and > that way, all ambiguity goes away. I would not want to have a world where we require that config, but I would agree to the latter, hence we would need to discuss "very simple". I guess that are 2 or 3 rules at most. > Part of the definition of "very simple" could be that the submodule > name must consist of some whitelisted list of characters (including no > uppercase), for example. Good catch! Thanks for chiming in, Stefan
