Re: [PATCH 02/21] read-cache.c: remove 'const' from index_has_changes()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 02/21] read-cache.c: remove 'const' from index_has_changes()
From: Stefan Beller <sbeller@xxxxxxxxxx>
Date: Tue, 28 Aug 2018 13:09:05 -0700
Cc: git <git@xxxxxxxxxxxxxxx>
In-reply-to: <CACsJy8CYUcL+BNBYqX51vCZXahG6sO03=GJZCihCvh8MLn3KqQ@mail.gmail.com>
References: <20180826100314.5137-1-pclouds@gmail.com> <20180826100314.5137-3-pclouds@gmail.com> <CAGZ79kbZRuzaoK=922b2JyfY9u8kOqm44KzKmbpWdWAkJ=SVDg@mail.gmail.com> <CACsJy8CYUcL+BNBYqX51vCZXahG6sO03=GJZCihCvh8MLn3KqQ@mail.gmail.com>

> "r" it is! I forgot about it. But this is for local variable or
> argument names only right? The field name (in diff_options for
> example) should stay something more descriptive like repo, I think.

Yea I agree, we should have more descriptive things in long lived structs.

Thanks,
Stefan

References:
- [PATCH 00/21] Kill the_index part 4
  - From: Nguyễn Thái Ngọc Duy
- [PATCH 02/21] read-cache.c: remove 'const' from index_has_changes()
  - From: Nguyễn Thái Ngọc Duy
- Re: [PATCH 02/21] read-cache.c: remove 'const' from index_has_changes()
  - From: Stefan Beller
- Re: [PATCH 02/21] read-cache.c: remove 'const' from index_has_changes()
  - From: Duy Nguyen

Prev by Date: [ANNOUNCE] Git v2.19.0-rc1
Next by Date: Re: [PATCH v4 4/6] tests: use shorter here-docs in chainlint.sed for AIX sed
Previous by thread: Re: [PATCH 02/21] read-cache.c: remove 'const' from index_has_changes()
Next by thread: [PATCH 05/21] grep.c: remove implicit dependency on the_index
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]

Powered by Linux