On Fri, Aug 24, 2018 at 5:14 AM Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote: > > For that reason, I was delighted to see that our Google Summer of Code > pushed pretty hard in that direction. And I could not help myself so I had > to test how much faster things got. Here is the result of my first, really > quick and dirty test: > > without builtin stash/rebase with builtin stash/rebase > t3400 (rebase) 1m27s 32s > t3404 (rebase -i) 13m15s 3m59s > t3903 (stash) 8m37s 1m18s > > What can I say? Even if the numbers are off by as much as 10%, these are > impressive improvements: keep in mind that there is a lot of churn going > on in the test suite because it is itself implemented in Unix shell > scripts (and hence I won't even bother to try more correct performance > benchmarking because that is simply not possible when Unix shell scripts > are in the equation). So the speed improvements of the stash/rebase > commands are *even higher* than this. Thanks for taking the time to make these pre-releases available. I appreciate the effort. And the same to Junio, for always posting release candidates. We rely on them heavily to find changes that might cause issues before admins start upgrading in the wild and find them for us. I downloaded both the rc0.1 and rc0.2 builds, as well as 2.18.0, and ran them all through Bitbucket Server's test suite a few times (to ensure warm disk for comparable numbers). I added support for some "simple" rebase cases a few releases ago, so we have a set of tests that verify the rebase behaviors we use. (We don't use git stash, so we don't have any tests in our suite for that.) Running our entire Git test suite (~1,600 tests) against Git for Windows 2.18.0 takes ~5 minutes, and 2.19.0-rc0.1 produced an almost identical duration. Running our tests against rc0.2 cut the duration down to 4 minutes. There were no test failures on either pre-release build. To try and get a better sense of the rebase performance improvement specifically, I filtered down to a set of 14 specific tests which use it and ran those. On Git 2.18, those 14 tests take just over 19 seconds. On 2.19.0-rc0.2, they take just over 8 seconds. When they do ship, whether it's in 2.19 (by default or optional) or later, the changes definitely offer some significant performance wins. Thanks again, to everyone involved, for all the effort that went into designing, implementing, reviewing and releasing these improvements. As someone who develops under Windows most of the time, they make a big difference in my day to day work. And that's not to mention all the Bitbucket Server and Bitbucket Data Center users who will enjoy a snappier experience as these changes make their way out into the wild. Best regards, Bryan Turner
