On Thu, Aug 23 2018, Eric Sunshine wrote:
> On Thu, Aug 23, 2018 at 4:36 PM Ævar Arnfjörð Bjarmason
> <avarab@xxxxxxxxx> wrote:
>> As noted in [1] there's still a remaining recently introduced
>> portability issue also introduced in 878f988350 ("t/test-lib: teach
>> --chain-lint to detect broken &&-chains in subshells", 2018-07-11), so
>> under AIX the tests must be run with GIT_TEST_CHAIN_LINT=0.
>>
>> I don't know how to solve the other issue, and this gets us some of
>> the way to GIT_TEST_CHAIN_LINT=1 working again on AIX.
>
> Does unindenting the comment, as I suggested in [1], fix the remaining
> problem for you?
>
> [1]: https://public-inbox.org/git/CAPig+cTTbU5HFMKgNyrxTp3+kcK46-Fn=4ZH6zDt1oQChAc3KA@xxxxxxxxxxxxxx/
I didn't notice Eric's E-mail before I sent my v3, so going back and
testing this revealed two things:
1) Yes, his suggestion works
2) AIX sed will complain about one thing at a time, so we had a lot
more of these "labels too long" problems once I got past fixing
that issue.
So here's a version, which as noted in 4/6 makes GIT_TEST_CHAIN_LINT=1
fully work on AIX again.
As an aside, the reason I have access to AIX is because I requested
access to the GCC compile farm as suggested by someone on-list here
the other day: https://cfarm.tetaneutral.net/
They accepted my account request on the basis that I was going to hack
on git & perl on those boxes, so if anyone else here is interested in
testing stuff for portability...
Ævar Arnfjörð Bjarmason (6):
tests: fix and add lint for non-portable head -c N
tests: fix and add lint for non-portable seq
tests: fix comment syntax in chainlint.sed for AIX sed
tests: use shorter here-docs in chainlint.sed for AIX sed
tests: fix version-specific portability issue in Perl JSON
tests: fix and add lint for non-portable grep --file
t/chainlint.sed | 59 ++++++++++++++--------------
t/check-non-portable-shell.pl | 3 ++
t/t0019/parse_json.perl | 3 ++
t/t5310-pack-bitmaps.sh | 2 +-
t/t5318-commit-graph.sh | 2 +-
t/t5552-skipping-fetch-negotiator.sh | 12 +++---
t/t5703-upload-pack-ref-in-want.sh | 4 +-
t/test-lib.sh | 4 +-
8 files changed, 47 insertions(+), 42 deletions(-)
--
2.18.0.865.gffc8e1a3cd6
