On Thu, Aug 23, 2018 at 9:30 AM Jeff King <peff@xxxxxxxx> wrote: > I think that audit isn't actually too bad (but definitely not something > we should do for v2.19). The cocci patch I showed earlier hits most of > them. It misses the negated ones (e.g., "if (oidcmp(...))"). I'm not > sure if there's a way to ask coccinelle only for oidcmp() > used in a boolean context. > You can look for explicitly "if (oidcmp(...))" though. I don't know if you can catch *any* use which degrades to boolean outside of an if statement, but I wouldn't expect there to be too many of those? Thanks, Jake
